Skip to content

fix(Tabs): remove height 100% style #5105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 13, 2025
Merged

fix(Tabs): remove height 100% style #5105

merged 2 commits into from
Jan 13, 2025

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jan 13, 2025 •
edited by sourcery-ai bot
Loading

remove height 100% style

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符；如果有关联 Issue 请在下方填写相关编号

Description

fixes #5104

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Fixes an issue where the height of the Tab component was fixed to 100%.

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 13, 2025 •
edited
Loading

Reviewer's Guide by Sourcery

This PR removes the height: 100% style from the Tab component to fix issue #5104.

Class diagram showing Tab component style changes

classDiagram
    class Tab {
        -styles
        +render()
    }
    note for Tab "Removed height: 100% style
from flex container"
Loading

File-Level Changes

Change Details Files
Removed the height: 100% style declaration src/BootstrapBlazor/Components/Tab/Tab.razor.scss

Assessment against linked issues

Issue Objective Addressed Explanation
#5104 Address the issue of excessive white space on the localization documentation page ❌ The PR removes a height: 100% style from a Tab component, but does not directly address the white space issue shown in the screenshots of the localization documentation page
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the documentation Improvements or additions to documentation label Jan 13, 2025
@bb-auto bb-auto bot added this to the v9.2.0 milestone Jan 13, 2025
sourcery-ai[bot]
sourcery-ai bot approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please complete the PR template with details about regression potential, risk assessment, and verification steps. Additionally, could you provide some context about what issues the height: 100% style was causing that led to this change?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang enabled auto-merge (squash) January 13, 2025 11:55
@codecov
Copy link

codecov bot commented Jan 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cd12a60) to head (3023cbe).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #5105   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          634       634           
  Lines        28159     28159           
  Branches      4039      4039           
=========================================
  Hits         28159     28159

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArgoZhang ArgoZhang merged commit 6a85589 into main Jan 13, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the feat-tabs branch January 13, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] approved these changes

Assignees

@ArgoZhang ArgoZhang

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

v9.2.0

Development

Successfully merging this pull request may close these issues.

doc(localization): 文档页面显示很多空白

2 participants

@ArgoZhang